[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Aug 22 14:07:17 PDT 2018
clayborg added inline comments.
================
Comment at: source/Target/Process.cpp:4692-4693
+ // the IOHandler for Editline).
+ bool cancel_top_handler = m_mod_id.IsRunningUtilityFunction();
+ GetTarget().GetDebugger().PushIOHandler(io_handler_sp, cancel_top_handler);
return true;
----------------
Another possible fix is to avoid pushing the IOHandler all together? Something like:
```
if (!m_mod_id.IsRunningUtilityFunction())
GetTarget().GetDebugger().PushIOHandler(io_handler_sp);
```
This would avoid an needed changes to the IOHandler stuff?
https://reviews.llvm.org/D50912
More information about the lldb-commits
mailing list