[Lldb-commits] [PATCH] D50864: Add libc++ data formatter for std::function

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik updated this revision to Diff 161837.
shafik marked 12 inline comments as done.
shafik added a comment.

Fixes based on comments

- Switched to early exits
- Added a lot more comments to explain all the cases being dealt with and noting which cases different sections are dealing with


https://reviews.llvm.org/D50864

Files:
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/main.cpp
  source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  source/Plugins/Language/CPlusPlus/LibCxx.cpp
  source/Plugins/Language/CPlusPlus/LibCxx.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50864.161837.patch
Type: text/x-patch
Size: 14380 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180821/e47de36f/attachment-0001.bin>