[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

[Keith Smiley via Phabricator via lldb-commits]

keith added inline comments.


================
Comment at: cmake/modules/LLDBFramework.cmake:21
   add_custom_command(TARGET lldb-framework POST_BUILD
     COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders $<TARGET_FILE_DIR:liblldb>/Headers
     COMMAND ${CMAKE_COMMAND} -E create_symlink Versions/Current/Headers ${LLDB_FRAMEWORK_DIR}/LLDB.framework/Headers
----------------
xiaobai wrote:
> This line shouldn't be necessary anymore then, right?
It still is, the change below doesn't actually do the copying, it only runs the script on the location the headers have already been copied too.


https://reviews.llvm.org/D49779