[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

[Alex Langford via Phabricator via lldb-commits]

xiaobai added a comment.

If I understand correctly, this is putting the headers directly into the framework? That's a pretty good idea :D

In https://reviews.llvm.org/D49779#1174659, @keith wrote:

> It seems like if this was a common occurrence, it would've been fixed earlier, so I'm wondering if there's a difference in the way I'm building lldb that causes this. Using cmake:
>
>   cmake ../llvm -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=YES -DLLDB_EXPORT_ALL_SYMBOLS=1 -DLLDB_BUILD_FRAMEWORK=ON
>
>
> And then `ninja lldb`, repeat `ninja lldb` builds causes ~500 files to be rebuilt with no source changes. I've diffed the `LLDB.framework` before and after and there don't seem to be any differences in the produced headers.


That's roughly how I build LLDB as well, give or take a few options.



================
Comment at: cmake/modules/LLDBFramework.cmake:21
   add_custom_command(TARGET lldb-framework POST_BUILD
     COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders $<TARGET_FILE_DIR:liblldb>/Headers
     COMMAND ${CMAKE_COMMAND} -E create_symlink Versions/Current/Headers ${LLDB_FRAMEWORK_DIR}/LLDB.framework/Headers
----------------
This line shouldn't be necessary anymore then, right?


https://reviews.llvm.org/D49779