[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik updated this revision to Diff 156886.
shafik marked 4 inline comments as done.
shafik added a comment.

Addressing comments

- -O0 is not needed in Makefile
- engaged is not friendly terminology so switching to "Has Value"
- Switching test away from lldbinline style due to bug w/ .categories files which does not work on these tests


https://reviews.llvm.org/D49271

Files:
  lldb.xcodeproj/project.pbxproj
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/main.cpp
  source/Plugins/Language/CPlusPlus/CMakeLists.txt
  source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  source/Plugins/Language/CPlusPlus/LibCxx.cpp
  source/Plugins/Language/CPlusPlus/LibCxx.h
  source/Plugins/Language/CPlusPlus/LibCxxOptional.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49271.156886.patch
Type: text/x-patch
Size: 14759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180723/a64cb080/attachment-0001.bin>