[Lldb-commits] [lldb] r337741 - [cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 23 14:14:52 PDT 2018


Author: teemperor
Date: Mon Jul 23 14:14:52 2018
New Revision: 337741

URL: http://llvm.org/viewvc/llvm-project?rev=337741&view=rev
Log:
[cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config

Summary:
LLDB_PLUGINS doesn't exist as a variable, so this line doesn't add any dependencies and is
just confusing. It seems this slipped in from the gdb-remote CMake I was using as a CMake template.

The gdb-remote CMake itself is using a local LLDB_PLUGINS variable, so that code is fine.

Reviewers: davide

Reviewed By: davide

Subscribers: davide, mgorny, lldb-commits

Differential Revision: https://reviews.llvm.org/D49695

Modified:
    lldb/trunk/source/Host/macosx/objcxx/CMakeLists.txt
    lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt

Modified: lldb/trunk/source/Host/macosx/objcxx/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/objcxx/CMakeLists.txt?rev=337741&r1=337740&r2=337741&view=diff
==============================================================================
--- lldb/trunk/source/Host/macosx/objcxx/CMakeLists.txt (original)
+++ lldb/trunk/source/Host/macosx/objcxx/CMakeLists.txt Mon Jul 23 14:14:52 2018
@@ -12,7 +12,6 @@ add_lldb_library(lldbHostMacOSXObjCXX
     lldbSymbol
     lldbTarget
     lldbUtility
-    ${LLDB_PLUGINS}
     ${EXTRA_LIBS}
 
   LINK_COMPONENTS

Modified: lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt?rev=337741&r1=337740&r2=337741&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt Mon Jul 23 14:14:52 2018
@@ -9,7 +9,6 @@ add_lldb_library(lldbPluginPlatformMacOS
     lldbSymbol
     lldbTarget
     lldbUtility
-    ${LLDB_PLUGINS}
     ${EXTRA_LIBS}
 
   LINK_COMPONENTS




More information about the lldb-commits mailing list