[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

Mon Jul 23 05:51:10 PDT 2018

sgraenitz marked an inline comment as done.
sgraenitz added a comment.

Quick local performance check doing `target create clang` in current review version vs. master HEAD version (both loading the exact same release build of clang) looks promising. It's faster already now, so I would remove the option for the builtin demangling.

  review version = LLDB_USE_LLVM_DEMANGLER:
  TargetList::CreateTarget (file = 'clang', arch = 'x86_64') = 0.762155337 sec

  master HEAD version = LLDB_USE_BUILTIN_DEMANGLER:
  TargetList::CreateTarget (file = 'clang', arch = 'x86_64') = 1.010040359 sec

https://reviews.llvm.org/D49612