[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB
Stefan Gränitz via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jul 23 04:26:58 PDT 2018
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:417-423
+ option(LLDB_USE_BUILTIN_DEMANGLER "Use lldb's builtin demangler" OFF)
+ option(LLDB_USE_LLVM_DEMANGLER "Use llvm's new partial demangler" ON)
> Since these options are mutually exclusive it might be better to make this a single multi-valued setting. Also, this new demangler should also be available in the MSVC case, should it not? Yhe reason we have `if(MSVC)` here is because the "system" demangler is not available there, but that should not be an issue here.
> I am talking about cmake code here.
Sorry, just saw that too.
> Since these options are mutually exclusive it might be better to make this a single multi-valued setting.
The old `LLDB_USE_BUILTIN_DEMANGLER` might be removed entirely once we have benchmark results. Otherwise I will make it multi-valued.
More information about the lldb-commits