[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB
Stefan Gränitz via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jul 23 03:19:53 PDT 2018
sgraenitz added a comment.
Hi all, thanks for your feedback. I will update the review with code fixes in a bit.
> Also we should compare demangled names between the two to ensure there are no differences as we are doing this.
Yes I can definitely do it manually. When it comes to writing tests, I would consider it more like testing the demangler itself than its integration with LLDB right? Shall we add tests in LLVM that compare to `__cxa_demangle`?
> running nm on a large executable (e.g. clang or lldb itself) and see whether we demangle in the same exact way and measure the time needed for demangling
Good idea, will try that.
> this new demangler should also be available in the MSVC case, should it not?
I don't think the Itanium mangler supports MSVC mangling.
> always add lldb-commits to the subscribers of your phab reviews
More information about the lldb-commits