[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 23 03:04:38 PDT 2018

labath added inline comments.

Comment at: cmake/modules/LLDBConfig.cmake:417-423
+    option(LLDB_USE_BUILTIN_DEMANGLER "Use lldb's builtin demangler" OFF)
+    option(LLDB_USE_LLVM_DEMANGLER "Use llvm's new partial demangler" ON)
+    add_definitions(-DLLDB_USE_LLVM_DEMANGLER)
Since these options are mutually exclusive it might be better to make this a single multi-valued setting. Also, this new demangler should also be available in the MSVC case, should it not? Yhe reason we have `if(MSVC)` here is because the "system" demangler is not available there, but that should not be an issue here.


More information about the lldb-commits mailing list