[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

[Hui Huang via Phabricator via lldb-commits]

Hui added inline comments.


================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:647-648
+        auto member_ast_type = type_sp->GetLayoutCompilerType();
+        if (!member_ast_type.IsCompleteType())
+          member_ast_type.GetCompleteType();
+        // CXX class type member must be parsed and complete ahead.
----------------
aleksandr.urakov wrote:
> It's not so important, but I think that these lines can be deleted if arguments of subsequent `if` will be flipped.
member udt or base class shall have all been completed before their parent 's completion. The 'if' is a double insurance? seeing a hard assert at line #659.


https://reviews.llvm.org/D49410