[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

[Hui Huang via Phabricator via lldb-commits]

Hui added inline comments.


================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:271-272
+    AccessType access = TranslateMemberAccess(udt->getAccess());
+    if (access == lldb::eAccessNone && udt->isNested() &&
+        udt->getClassParent()) {
+      access = GetDefaultAccessibilityForUdtKind(udt_kind);
----------------
zturner wrote:
> So is this `access == None` a thing that can actually happen?  AFAICT it's impossible for `getAccess()` to return anything other than public, protected, or private, in which case this code path will never get executed, so we can just delete it.
Chance is that udt->getAccess() could return PDB_MemberAccess() (ctor) if the DIA call fails. Need to check if CodeView generates default access for a nested udt or not. I think. 


https://reviews.llvm.org/D49410