[Lldb-commits] [lldb] r336377 - Fixed redefinition warnings with LLVM_ENABLE_MODULES

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 5 10:12:11 PDT 2018

Author: teemperor
Date: Thu Jul  5 10:12:11 2018
New Revision: 336377

URL: http://llvm.org/viewvc/llvm-project?rev=336377&view=rev
Fixed redefinition warnings with LLVM_ENABLE_MODULES

It seems we both have the HAVE_LIBCOMPRESSION define in the config header
and in the source files definitions of some files. This causes that the
Config.h header emits the following warning when we compile the Host module:

In file included from <module-includes>:21:
In file included from /Users/teemperor/llvm/llvm/tools/lldb/include/lldb/Host/MainLoop.h:13:
tools/lldb/include/lldb/Host/Config.h:33:9: warning: 'HAVE_LIBCOMPRESSION' macro redefined [-Wmacro-redefined]
<command line>:1:9: note: previous definition is here

It's not really clear why the define is in both places (the commit message
just says it fixes some unspecified bug), but we can easily work around this
by just guarding our define in Config.h.

Reviewers: aprantl

Reviewed By: aprantl

Subscribers: mgorny, lldb-commits

Differential Revision: https://reviews.llvm.org/D48977


Modified: lldb/trunk/include/lldb/Host/Config.h.cmake
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/Config.h.cmake?rev=336377&r1=336376&r2=336377&view=diff
--- lldb/trunk/include/lldb/Host/Config.h.cmake (original)
+++ lldb/trunk/include/lldb/Host/Config.h.cmake Thu Jul  5 10:12:11 2018
@@ -30,6 +30,8 @@
 #cmakedefine01 HAVE_NR_PROCESS_VM_READV
 #endif // #ifndef LLDB_HOST_CONFIG_H

More information about the lldb-commits mailing list