[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Sorry, I wasn't clear.  Suppose that the `m_thread_idx` coming into DoExecute is LLDB_INVALID_THREAD_ID.  That's what happens if you don't select a thread id on the command line, for instance.  Then the code around 1164 will set `thread` to be the default thread.  But `m_thread_idx` will still be LLDB_INVALID_THREAD_ID.  Then for instance if the selected frame of `thread` has no debug info, the error messages will read:

Frame index 0 of thread index  4294967295 has no debug information.

(the value of LLDB_INVALID_THREAD_ID) since the error is still printing `m_thread_idx` .  The errors also need to print `thread->GetID()`...


https://reviews.llvm.org/D48865