[Lldb-commits] [PATCH] D48796: Refactoring for for the internal command line completion API (NFC)

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 2 12:34:34 PDT 2018

jingham added a comment.

This patch looks fine, I agree with Pavel the direction is good.  It seems like you would reduce a bunch of boiler-plate if you changed over InvokeCommonCompletionCallbacks to take a CompletionRequest.  Was there something that blocked you from doing that?


More information about the lldb-commits mailing list