[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 2 08:21:31 PDT 2018

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with the inline keyword removed.

Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:24
+namespace {
+inline const CMICmnMIValueTuple
+CreateMITuplePCLine(const uint32_t addr, const uint32_t line_number) {
apolyakov wrote:
> aprantl wrote:
> > Please remove the `inline` keyword. LLVM will inline if it's profitable anyway.
> > Also: could this be a constructor of CMImnMIValueTuple?
> I think it could not. There are specific strings like "0x", "pc", "line" in this function which don't have any relation to CMICmnMIValueTuple class. Also, passing them as arguments doesn't seem like a good way. But it can be discussed, maybe someone will suggest a good approach for dealing with it.
I see in that case keeping it local to this file seems like the better approach.


More information about the lldb-commits mailing list