[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jun 30 15:03:55 PDT 2018

apolyakov added inline comments.

Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:24
+namespace {
+inline const CMICmnMIValueTuple
+CreateMITuplePCLine(const uint32_t addr, const uint32_t line_number) {
aprantl wrote:
> Please remove the `inline` keyword. LLVM will inline if it's profitable anyway.
> Also: could this be a constructor of CMImnMIValueTuple?
I think it could not. There are specific strings like "0x", "pc", "line" in this function which don't have any relation to CMICmnMIValueTuple class. Also, passing them as arguments doesn't seem like a good way. But it can be discussed, maybe someone will suggest a good approach for dealing with it.


More information about the lldb-commits mailing list