[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jun 30 09:48:19 PDT 2018

aprantl added a comment.

This is going to be really nice!

Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:24
+namespace {
+inline const CMICmnMIValueTuple
+CreateMITuplePCLine(const uint32_t addr, const uint32_t line_number) {
Please remove the `inline` keyword. LLVM will inline if it's profitable anyway.
Also: could this be a constructor of CMImnMIValueTuple?


More information about the lldb-commits mailing list