[Lldb-commits] [PATCH] D48633: UUID: Add support for arbitrary-sized module IDs

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 27 07:27:47 PDT 2018

clayborg added inline comments.

Comment at: source/Interpreter/OptionValueUUID.cpp:82
+      llvm::SmallVector<uint8_t, 20> uuid_bytes;
+      UUID::DecodeUUIDBytesFromString(s, uuid_bytes);
       for (size_t i = 0; i < num_modules; ++i) {
Probably should have a return value that indicates success or not. What if the user enters "aab". The string must have an event number of hex digits.


More information about the lldb-commits mailing list