[Lldb-commits] [PATCH] D48633: UUID: Add support for arbitrary-sized module IDs

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Interpreter/OptionValueUUID.cpp:82
+      llvm::SmallVector<uint8_t, 20> uuid_bytes;
+      UUID::DecodeUUIDBytesFromString(s, uuid_bytes);
       for (size_t i = 0; i < num_modules; ++i) {
----------------
Probably should have a return value that indicates success or not. What if the user enters "aab". The string must have an event number of hex digits.


https://reviews.llvm.org/D48633