[Lldb-commits] [PATCH] D48633: UUID: Add support for arbitrary-sized module IDs

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, lemo, sas, davide.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.

The data structure is optimized for the case where the UUID size is <=
20 bytes (standard length emitted by the GNU linkers), but larger sizes
are also possible.

I've modified the string conversion function to support the new sizes as
well. For standard UUIDs it maintains the traditional formatting
(4-2-2-2-6). If a UUID is shorter, we just cut this sequence short, and
for longer UUIDs it will just repeat the last 6-byte block as long as
necessary.

I've also modified ObjectFileELF to take advantage of the new UUIDs and
avoid manually padding the UUID to 16 bytes. While there, I also made
sure the computed UUID does not depend on host endianness.


https://reviews.llvm.org/D48633

Files:
  include/lldb/Utility/UUID.h
  source/Interpreter/OptionValueUUID.cpp
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
  source/Utility/UUID.cpp
  unittests/Utility/UUIDTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48633.153048.patch
Type: text/x-patch
Size: 14839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180627/adc9e09a/attachment-0001.bin>