[Lldb-commits] [PATCH] D48295: [WIP] Implement new ReturnMIStatus method of CMICmdBase class.
Alexander Polyakov via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 20 05:29:45 PDT 2018
apolyakov updated this revision to Diff 152069.
apolyakov added a comment.
Changed method's name from `ReturnMIStatus` to `HandleSBError`. Also added one more use case(see -exec-step's Execute function).
The only thing that worries me is that if we want to specify handler for error case, we should do something like:
SBError error = ...
auto errorHandler = ...
return HandleSBError(error, [] { return MIstatus::success; }, errorHandler);
since in C++ we can't skip first optional argument and only pass second one.
https://reviews.llvm.org/D48295
Files:
tools/lldb-mi/MICmdBase.cpp
tools/lldb-mi/MICmdBase.h
tools/lldb-mi/MICmdCmdExec.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48295.152069.patch
Type: text/x-patch
Size: 3834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180620/be89c7c9/attachment.bin>
More information about the lldb-commits
mailing list