[Lldb-commits] [lldb] r335047 - Attempt to fix windows build broken by r334968
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 19 07:23:31 PDT 2018
Author: labath
Date: Tue Jun 19 07:23:31 2018
New Revision: 335047
URL: http://llvm.org/viewvc/llvm-project?rev=335047&view=rev
Log:
Attempt to fix windows build broken by r334968
The issue was that there was no dependency from lldb-suite target to liblldb in
the no-framework scenario. This caused the finish-swig target to be executed
prematurely and fail (because it cannot copy liblldb to the python folder). On
other platforms this did not matter because there just creates a symlink.
The extra lldb-suite -> liblldb edge should fix this. Technically, I could add
this just to the !framework case as the framework target will take care of the
transitive dep, but it seemed more clear to make the dep unconditional.
Modified:
lldb/trunk/CMakeLists.txt
Modified: lldb/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=335047&r1=335046&r2=335047&view=diff
==============================================================================
--- lldb/trunk/CMakeLists.txt (original)
+++ lldb/trunk/CMakeLists.txt Tue Jun 19 07:23:31 2018
@@ -152,6 +152,7 @@ if (LLDB_BUILD_FRAMEWORK)
include(LLDBFramework)
add_dependencies(lldb-suite lldb-framework)
endif()
+add_dependencies(lldb-suite liblldb)
if (NOT LLDB_DISABLE_PYTHON)
# Add a Post-Build Event to copy over Python files and create the symlink
More information about the lldb-commits
mailing list