[Lldb-commits] [PATCH] D48295: [WIP] Implement new ReturnMIStatus method of CMICmdBase class.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: tools/lldb-mi/MICmdBase.cpp:221
+// Args:    error - (R) Error description object.
+// Return:  None.
+// Throws:  None.
----------------
apolyakov wrote:
> aprantl wrote:
> > It returns a bool, right?
> > 
> > At some point it sure would be nice if we could convert the lldb-mi sources over to the LLVM coding style ...
> Yep, it does. I'll update this.
> 
> Is there some code in this commit that doesn't correspond to LLVM coding style?
I was referring to the variable naming and documentation schema, which is very different from what the rest of the code uses. You are doing the right thing here, you're matching the new code to whatever style is used by the file.


https://reviews.llvm.org/D48295