[Lldb-commits] [PATCH] D48295: [WIP] Implement new ReturnMIStatus method of CMICmdBase class.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 18 14:04:14 PDT 2018


apolyakov added inline comments.


================
Comment at: tools/lldb-mi/MICmdBase.cpp:221
+// Args:    error - (R) Error description object.
+// Return:  None.
+// Throws:  None.
----------------
aprantl wrote:
> It returns a bool, right?
> 
> At some point it sure would be nice if we could convert the lldb-mi sources over to the LLVM coding style ...
Yep, it does. I'll update this.

Is there some code in this commit that doesn't correspond to LLVM coding style?


https://reviews.llvm.org/D48295





More information about the lldb-commits mailing list