[Lldb-commits] [PATCH] D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails

[Greg Clayton via lldb-commits]

Should not have spaces before any ( characters. What you typed looks good. 

> On Jun 11, 2018, at 2:00 PM, Leonard Mosescu <mosescu at google.com> wrote:
> 
> remove space before (
>  
> I'd be happy to make the change, but looking at the rest of the file it seems that almost everything uses the opposite convention: Foo (...). 
> 
> So, to make sure I'm making the right change, is this how it should look?
> 
>     lldb::SBProcess
>     LoadCore(const char *core_file);
> 
>     lldb::SBProcess
>     LoadCore(const char *core_file, lldb::SBError &error);
> 
> 
> On Mon, Jun 11, 2018 at 1:47 PM, Greg Clayton via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> clayborg accepted this revision.
> clayborg added a comment.
> This revision is now accepted and ready to land.
> 
> Remove extra spaces before ( and good to go.
> 
> 
> 
> ================
> Comment at: scripts/interface/SBTarget.i:282
>      lldb::SBProcess
> -    LoadCore(const char *core_file);
> -    
> +    LoadCore (const char *core_file);
> +
> ----------------
> remove space before (
> 
> 
> ================
> Comment at: scripts/interface/SBTarget.i:285
> +    lldb::SBProcess
> +    LoadCore (const char *core_file, lldb::SBError &error);
> +
> ----------------
> remove space before (
> 
> 
> ================
> Comment at: scripts/interface/SBTarget.i:288
>      lldb::SBProcess
>      Attach (lldb::SBAttachInfo &attach_info, lldb::SBError& error);
> 
> ----------------
> remove space before (
> 
> 
> https://reviews.llvm.org/D48049 <https://reviews.llvm.org/D48049>
> 
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180611/2c0f3243/attachment.html>