<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Should not have spaces before any ( characters. What you typed looks good. <br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jun 11, 2018, at 2:00 PM, Leonard Mosescu <<a href="mailto:mosescu@google.com" class="">mosescu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-size:12.8px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class="">remove space before (</span><br class=""></blockquote><div class=""> </div>I'd be happy to make the change, but looking at the rest of the file it seems that almost everything uses the opposite convention: Foo (...). <div class=""><br class=""></div><div class="">So, to make sure I'm making the right change, is this how it should look?</div><div class=""><br class=""></div><div class=""><div class=""> lldb::SBProcess</div><div class=""> LoadCore(const char *core_file);</div><div class=""><br class=""></div><div class=""> lldb::SBProcess</div><div class=""> LoadCore(const char *core_file, lldb::SBError &error);</div></div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Jun 11, 2018 at 1:47 PM, Greg Clayton via Phabricator <span dir="ltr" class=""><<a href="mailto:reviews@reviews.llvm.org" target="_blank" class="">reviews@reviews.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">clayborg accepted this revision.<br class="">
clayborg added a comment.<br class="">
This revision is now accepted and ready to land.<br class="">
<br class="">
Remove extra spaces before ( and good to go.<br class="">
<br class="">
<br class="">
<br class="">
================<br class="">
Comment at: scripts/interface/SBTarget.i:<wbr class="">282<br class="">
lldb::SBProcess<br class="">
- LoadCore(const char *core_file);<br class="">
- <br class="">
+ LoadCore (const char *core_file);<br class="">
+<br class="">
----------------<br class="">
remove space before (<br class="">
<br class="">
<br class="">
================<br class="">
Comment at: scripts/interface/SBTarget.i:<wbr class="">285<br class="">
+ lldb::SBProcess<br class="">
+ LoadCore (const char *core_file, lldb::SBError &error);<br class="">
+<br class="">
----------------<br class="">
remove space before (<br class="">
<br class="">
<br class="">
================<br class="">
Comment at: scripts/interface/SBTarget.i:<wbr class="">288<br class="">
lldb::SBProcess<br class="">
Attach (lldb::SBAttachInfo &attach_info, lldb::SBError& error);<br class="">
<br class="">
----------------<br class="">
remove space before (<br class="">
<br class="">
<br class="">
<a href="https://reviews.llvm.org/D48049" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D48049</a><br class="">
<br class="">
<br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>