[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

[Frédéric Riss via lldb-commits]

> On May 8, 2018, at 1:32 AM, Pavel Labath via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> labath added a comment.
> 
> One could probably concoct an example (using macros, token pasting and such) where this would get it wrong, but that's probably not worth supporting.

Yeah, I thought about this and I’m not sure it’s worth supporting. We could support it by doing the filtering after a round of pre-processing, but it seems really overkill. 

> 
> 
> ================
> Comment at: source/Expression/ExpressionSourceCode.cpp:193
> +        var_name == ConstString(".block_descriptor") ||
> +        !ExprBodyContainsVar(var_name.AsCString(), expr))
>       continue;
> ----------------
> `s/AsCString/GetStringRef` (saves a `strlen` operation).

Thanks,
Fred

> 
> https://reviews.llvm.org/D46551
> 
> 
>