[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

One could probably concoct an example (using macros, token pasting and such) where this would get it wrong, but that's probably not worth supporting.



================
Comment at: source/Expression/ExpressionSourceCode.cpp:193
+        var_name == ConstString(".block_descriptor") ||
+        !ExprBodyContainsVar(var_name.AsCString(), expr))
       continue;
----------------
`s/AsCString/GetStringRef` (saves a `strlen` operation).


https://reviews.llvm.org/D46551