[Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 6 09:32:37 PDT 2018

On Fri, Apr 6, 2018 at 1:02 AM, Jan Kratochvil via Phabricator
<reviews at reviews.llvm.org> wrote:
> jankratochvil added a comment.
> I disagree with this patch as `DWARFUnit` was a lightweight wrapper for `DWARFPartialUnit`.  Now I will have to create some new lightweight superclass like `DWARFAbstractUnit`.
> My patch prepared it for:
>   DWARFUnit->DWARFCompileUnit
>   DWARFUnit->DWARFPartialUnit
> And I planned the type units should be implemented like:
>   DWARFUnit->DWARFSomeNameUnit->DWARFCompileUnit
>   DWARFUnit->DWARFSomeNameUnit->DWARFTypeUnit
>   DWARFUnit->DWARFPartialUnit
> This patch just reused + changed my abstraction for a completely different purpose and I will have to reimplement it again under a different name.  Or what do you suggest?

As there's some disagreement on how to proceed forward, we can
probably revert this for now and start a discussion.
You can probably do it yourself.


More information about the lldb-commits mailing list