[Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 6 01:02:07 PDT 2018
jankratochvil added a comment.
I disagree with this patch as `DWARFUnit` was a lightweight wrapper for `DWARFPartialUnit`. Now I will have to create some new lightweight superclass like `DWARFAbstractUnit`.
My patch prepared it for:
And I planned the type units should be implemented like:
This patch just reused + changed my abstraction for a completely different purpose and I will have to reimplement it again under a different name. Or what do you suggest?
More information about the lldb-commits