[Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

I disagree with this patch as `DWARFUnit` was a lightweight wrapper for `DWARFPartialUnit`.  Now I will have to create some new lightweight superclass like `DWARFAbstractUnit`.
My patch prepared it for:

  DWARFUnit->DWARFCompileUnit
  DWARFUnit->DWARFPartialUnit

And I planned the type units should be implemented like:

  DWARFUnit->DWARFSomeNameUnit->DWARFCompileUnit
  DWARFUnit->DWARFSomeNameUnit->DWARFTypeUnit
  DWARFUnit->DWARFPartialUnit

This patch just reused + changed my abstraction for a completely different purpose and I will have to reimplement it again under a different name.  Or what do you suggest?


Repository:
  rL LLVM

https://reviews.llvm.org/D45170