[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks! I think this makes sense.



================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:707
+        """Create the test-specific working directory, deleting any previous
+        contents."""
         # See also dotest.py which sets up ${LLDB_BUILD}.
----------------
I was thinking whether this was necessary, since we could just `rm -rf` the entire --build-dir, but for running individual tests, doing it this way makes it easier.


================
Comment at: test/CMakeLists.txt:9
   add_custom_target(${name}
     # Clear the test directory first.
     COMMAND ${PYTHON_TEST_COMMAND} ${ARG_DEFAULT_ARGS}
----------------
That comment is obsolete now?


https://reviews.llvm.org/D44526