[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added a reviewer: aprantl.
Herald added subscribers: eraman, mgorny, ki.stfu, emaste.

This patch implements a unified way of cleaning the build folder of each
test. This is done by completely removing the build folder before each
test, in the respective setUp() method. Previously, we were using a
combination of several methods, each with it's own drawbacks:

- nuking the entire build tree before running dotest: the issue here is that this did not take place if you ran dotest manually
- running "make clean" before the main "make" target: this relied on the clean command being correctly implemented. This was usually true, but not always.
- for files which were not produced by make, each python file was responsible for ensuring their deleting, using a variety of methods.

With this approach, the previous methods become redundant. I remove the
first two, since they are centralized. For the other various bits of
clean-up code in python files, I indend to delete it when I come
across it.


https://reviews.llvm.org/D44526

Files:
  packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py
  packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
  packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
  packages/Python/lldbsuite/test/linux/add-symbols/TestTargetSymbolsAddCommand.py
  packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py
  packages/Python/lldbsuite/test/lldbinline.py
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/macosx/add-dsym/TestAddDsymMidExecutionCommand.py
  packages/Python/lldbsuite/test/plugins/builder_base.py
  packages/Python/lldbsuite/test/plugins/builder_darwin.py
  packages/Python/lldbsuite/test/plugins/builder_freebsd.py
  packages/Python/lldbsuite/test/plugins/builder_linux.py
  packages/Python/lldbsuite/test/plugins/builder_netbsd.py
  packages/Python/lldbsuite/test/plugins/builder_win32.py
  packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py
  packages/Python/lldbsuite/test/warnings/uuid/TestAddDsymCommand.py
  test/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44526.138579.patch
Type: text/x-patch
Size: 20106 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180315/820ba220/attachment-0001.bin>