[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha updated this revision to Diff 135711.
tatyana-krasnukha added a comment.

Have no idea how to know about working around breakpoints for read and write separately. Just rely on support of Z-packets for now.
This expectation could be fair, however...

In https://reviews.llvm.org/D39967#1017764, @ted wrote:

> It should. If it doesn't, then a write over a breakpoint would clobber it.


it doesn't for now.


https://reviews.llvm.org/D39967

Files:
  include/lldb/Breakpoint/BreakpointSiteList.h
  include/lldb/Target/Process.h
  source/Breakpoint/BreakpointSiteList.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  source/Target/Process.cpp
  unittests/Process/CMakeLists.txt
  unittests/Process/common/
  unittests/Process/common/CMakeLists.txt
  unittests/Process/common/ProcessWriteMemoryTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39967.135711.patch
Type: text/x-patch
Size: 27532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180223/e57e04c5/attachment-0001.bin>