[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

[Ted Woodward via Phabricator via lldb-commits]

ted added a comment.

In https://reviews.llvm.org/D39967#1017754, @labath wrote:

> I believe lldb-server does not work around breakpoint opcodes during writing (it does for reading), but that can be fixed, of course.


It should. If it doesn't, then a write over a breakpoint would clobber it.

What should happen is lldb-server finds all breakpoint locations in a write, and replaces the saved opcode for each such breakpoint with the corresponding value in the write, then writes the data to memory. Breakpoint addresses can either be skipped, or have the opcode in them replaced by the breakpoint opcode before the write.


https://reviews.llvm.org/D39967