[Lldb-commits] [PATCH] D43662: [Utility] Simplify and generalize the CleanUp helper, NFC

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 11:27:46 PST 2018


vsk updated this revision to Diff 135671.
vsk added a comment.
Herald added a subscriber: mgorny.

Thanks for the feedback.

I've added support for forwarding arguments to the cleanup function though the constructor. It uses std::bind instead of a lambda because I couldn't figure out a simpler way to support reference arguments. (Btw, llvm::ThreadPool does the same thing.)

I've also added a unit test. PTAL.


https://reviews.llvm.org/D43662

Files:
  include/lldb/Utility/CleanUp.h
  lldb.xcodeproj/project.pbxproj
  source/Host/macosx/Host.mm
  source/Host/macosx/Symbols.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  unittests/Utility/CMakeLists.txt
  unittests/Utility/CleanUpTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43662.135671.patch
Type: text/x-patch
Size: 24019 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180223/d6e8e82c/attachment-0001.bin>


More information about the lldb-commits mailing list