[Lldb-commits] [PATCH] D43662: [Utility] Simplify and generalize the CleanUp helper, NFC

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 00:50:53 PST 2018


JDevlieghere added a comment.

I agree with Pavel, I prefer having a slightly more complex constructor if we can make the call sites simpler for the simple common cases, especially since we don't lose any generality by doing so. It's also not an uncommon pattern in C++, e.g. `std::async` does something very similar.

Also +1 on just calling operator bool on the function itself.


https://reviews.llvm.org/D43662





More information about the lldb-commits mailing list