[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: Python/lldbsuite/test/expression_command/call-overridden-method/main.cpp:15
+  Base *b = &d;
+  return 0; // Please test these expressions while stopped at this line:
+}
----------------
aprantl wrote:
> the expressions are missing :-)
> Perhaps convert this into an inline testcase?
The expressions are in the test .py file.  It isn't necessary to put them here, I'd just fix the comment.

Please don't convert regular test cases into inline ones, however.  The benefit of inline test cases is mostly that they are easier to write, but they are harder to debug when they go wrong.  So if the are already in regular form I'd rather not convert them.


Repository:
  rL LLVM

https://reviews.llvm.org/D41997