[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

Awesome!



================
Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2103
 
+static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethodDecl *m2) {
+  // FIXME: This should detect covariant return types, but currently doesn't.
----------------
Could you add some doxygen comments explaining what the new function do and why doing this is necessary?


================
Comment at: Python/lldbsuite/test/expression_command/call-overridden-method/TestCallOverriddenMethod.py:14
+
+from __future__ import print_function
+
----------------
where is this used?


================
Comment at: Python/lldbsuite/test/expression_command/call-overridden-method/main.cpp:15
+  Base *b = &d;
+  return 0; // Please test these expressions while stopped at this line:
+}
----------------
the expressions are missing :-)
Perhaps convert this into an inline testcase?


Repository:
  rL LLVM

https://reviews.llvm.org/D41997