[Lldb-commits] [lldb] r321856 - [ArchSpec] Don't consider Unknown MachO64 as invalid.

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 9 08:55:04 PST 2018

On 9 January 2018 at 15:26, Davide Italiano <dccitaliano at gmail.com> wrote:
> On Tue, Jan 9, 2018 at 5:02 AM, Pavel Labath <labath at google.com> wrote:
>> The inheritance trick can be useful sometimes, but I don't think it's
>> a good way to write tests in general (and it should not be necessary
>> for this patch).
>> I assume you ran into this while working on a real-world bug. How were
>> the relevant ArchSpecs constructed there? The class is fairly simple,
>> so it should be easy to replicate the construction here (probably just
>> involves passing the correct triple string to the ArchSpec
>> constructor)...
>> Did you try that approach?
> Yes, I did. This is for a non-public triple but still wanted some
> coverage of the behavior upstream.

Ah, I see. Thanks for the explanation.

More information about the lldb-commits mailing list