[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 9 05:10:32 PST 2018

labath added a comment.

In https://reviews.llvm.org/D41725#969388, @mgorny wrote:

> I was talking of:
>   source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
>   source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

Ah, right. These uses were introduced before we developed a preference for llvm primitives. That said, I see a lot of compression stuff there, but I don't see mention of zlib directly.

>   tools/debugserver/source/RNBRemote.cpp

Debugserver does not use llvm on purpose, but that should only worry you if your targetting darwin.

In any case, lgtm.


More information about the lldb-commits mailing list