[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jan 6 02:15:21 PST 2018

mgorny added a comment.

Well, it's actually more complex. In Gentoo we want to let the user choose whether he wants to build against zlib or without zlib support. So in the end there are two uses to be considered:

1. When the value is merely passed down from LLVM to indicate state of compression support in LLVM. AFAIR that was the case with clang -- we merely wanted to know if we can run tests that require LLVM to have compression support.
2. When the value is actually used to use zlib locally. To be honest, in this case I believe we should have a separate check & switch. FWICS, this is the case with LLDB.

So I don't think using LLVM_ENABLE_ZLIB here is correct, and my patch isn't correct as well.

That said, is there a reason for LLDB to use zlib directly instead of using the LLVM support compression library?


More information about the lldb-commits mailing list