[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jan 6 01:44:51 PST 2018

labath added a comment.

In https://reviews.llvm.org/D41725#969183, @mgorny wrote:

> Maybe we could. I presumed people are using the separate variables for some reason. We'd have to check that it's properly sanitized when building in-tree and given to cmake though.

I would expect that reason is purely historical. While working on that patch I got the feeling that there is a lot of confusion in how to check for zlib presence. All everyone wants to know is whether zlib is present and working, so there should not be a need for different checks. We certainly don't need anything fancy here.


More information about the lldb-commits mailing list