[Lldb-commits] [lldb] r320456 - Avoid module import in a textual header, NFC

[Vedant Kumar via lldb-commits]

Ah sorry, didn't see this for a while!

Yes -- I agree on both points here.

vedant

> On Dec 11, 2017, at 9:07 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Long term it would be nice if we could get all these register definitions automatically generated with llvm-tblgen.  That's a big undertaking, though.
> 
> On Mon, Dec 11, 2017 at 7:27 PM Vedant Kumar via lldb-commits <lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>> wrote:
> Author: vedantk
> Date: Mon Dec 11 19:27:13 2017
> New Revision: 320456
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=320456&view=rev <http://llvm.org/viewvc/llvm-project?rev=320456&view=rev>
> Log:
> Avoid module import in a textual header, NFC
> 
> This unbreaks the lldb modules build (-DLLVM_ENABLE_MODULES=On).
> 
> Modified:
>     lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h
> 
> Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h?rev=320456&r1=320455&r2=320456&view=diff <http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h?rev=320456&r1=320455&r2=320456&view=diff>
> ==============================================================================
> --- lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h (original)
> +++ lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h Mon Dec 11 19:27:13 2017
> @@ -7,11 +7,8 @@
>  //
>  //===----------------------------------------------------------------------===//
> 
> -#include "llvm/Support/Compiler.h"
> -#include <cstddef>
> -#include <cstdint>
> -
> -// Project includes
> +// This file is meant to be textually included. Do not #include modular
> +// headers here.
> 
>  // Computes the offset of the given GPR in the user data area.
>  #define GPR_OFFSET(regname) (LLVM_EXTENSION offsetof(GPR, regname))
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171213/b0b909bb/attachment.html>