<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ah sorry, didn't see this for a while!<div class=""><br class=""></div><div class="">Yes -- I agree on both points here.</div><div class=""><br class=""></div><div class="">vedant</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 11, 2017, at 9:07 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Long term it would be nice if we could get all these register definitions automatically generated with llvm-tblgen. That's a big undertaking, though.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Dec 11, 2017 at 7:27 PM Vedant Kumar via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vedantk<br class="">
Date: Mon Dec 11 19:27:13 2017<br class="">
New Revision: 320456<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=320456&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=320456&view=rev</a><br class="">
Log:<br class="">
Avoid module import in a textual header, NFC<br class="">
<br class="">
This unbreaks the lldb modules build (-DLLVM_ENABLE_MODULES=On).<br class="">
<br class="">
Modified:<br class="">
lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h<br class="">
<br class="">
Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h?rev=320456&r1=320455&r2=320456&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h?rev=320456&r1=320455&r2=320456&view=diff</a><br class="">
==============================================================================<br class="">
--- lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h (original)<br class="">
+++ lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h Mon Dec 11 19:27:13 2017<br class="">
@@ -7,11 +7,8 @@<br class="">
//<br class="">
//===----------------------------------------------------------------------===//<br class="">
<br class="">
-#include "llvm/Support/Compiler.h"<br class="">
-#include <cstddef><br class="">
-#include <cstdint><br class="">
-<br class="">
-// Project includes<br class="">
+// This file is meant to be textually included. Do not #include modular<br class="">
+// headers here.<br class="">
<br class="">
// Computes the offset of the given GPR in the user data area.<br class="">
#define GPR_OFFSET(regname) (LLVM_EXTENSION offsetof(GPR, regname))<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>