[Lldb-commits] [PATCH] D38568: [lldb] Enable using out-of-tree dwps

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer added inline comments.


================
Comment at: source/Host/common/Symbols.cpp:288-294
+              // FIXME: at the moment llvm-dwp doesn't output build ids,
+              // nor does binutils dwp. Thus in the case of DWPs
+              // we skip uuids check. This needs to be fixed
+              // to avoid consistency issues as soon as
+              // llvm-dwp and binutils dwp gain support for build ids.
+              if (file_spec.GetFileNameExtension().GetStringRef() == "dwp" ||
+                  mspec.GetUUID() == module_uuid)
----------------
What do you think about adding a new argument to Symbols::LocateExecutableSymbolFile (with a potential default value) to specify if we want to check the UUID and then move this logic to the place where we are looking for the dwp file? I think that would make dwp specific logic more concise in one place.


Repository:
  rL LLVM

https://reviews.llvm.org/D38568