[Lldb-commits] [PATCH] D37926: Fix the SIGINT handlers

Leonard Mosescu via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 15 13:42:31 PDT 2017

How would that fix look? If the intention is to ignore nested SIGINT then
doing it directly in the handler seems cleaner and safer (re. safety, note
that m_input_reader_stack.GetMutex() is a std::*recursive_*mutex so
depending on it in signal handlers is a big no-no. The recursive_mutex
looks like a red flag in itself, but that's something for another day)

On Fri, Sep 15, 2017 at 1:34 PM, Zachary Turner via Phabricator <
reviews at reviews.llvm.org> wrote:

> zturner added a comment.
> It turns out the function this called, `DispatchInputInterrupt`, already
> acquires a mutex.  Maybe put the synchronization in there?  Then you don't
> have to reproduce the synchronization in both MI and LLDB
> https://reviews.llvm.org/D37926
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170915/aadfeb8c/attachment.html>

More information about the lldb-commits mailing list