[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I looked at this briefly last week but I could not find a good fix in the amount of time I had left. This fixes the current test failure, but it does not fix the underlying bug, which is that we (sometimes?) set the compile unit offset for non-dwo, non-dsym DIEs as 0. This works fine if all compile units are regular dwarf as we have logic to locate the containing CU if the offset is zero. However, it can fail in case of mixed dwarf and dwo compile units. My guess is you could still reproduce this bug with a so file that has a dwo compile unit at offset zero.

That said, I don't think this makes things any worse, so I have no objections to this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D35740