[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

[Pavel Labath via Phabricator via lldb-commits]

labath added a reviewer: eugene.
labath added a comment.

I am not able to test this right now. Eugene, can you take a look?



================
Comment at: tools/lldb-server/lldb-gdbserver.cpp:241
+  std::unique_ptr<Connection> connection_up;
+  if (connection_fd != -1) {
+    // Build the connection string.
----------------
you should set the O_CLOEXEC flag on the file descriptor, to avoid leakage.


https://reviews.llvm.org/D33213