[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

Can you file a bug about this issue so we can keep track of it? Also it would be nice to include a small test case in the bug (if you have one) what demonstrates the crash as so far I only managed to see missing type information without an actual LLDB crash.



================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:513
+      return 0;
+    }
+
----------------
clayborg wrote:
> That patch would be a lot more intrusive as we would still need to be able to parse all compile unit DIEs just so we can get to the line tables. The only way to find the line table for a compile unit is to follow the DW_AT_stmt_list attribute in each top level compile unit DIE. Also, DWARF is useless to us unless we index the DWARF, which means parsing everything in all DIEs. I would like to keep this as simple as possible to just avoid the issue for now. This make it easy to cherry pick this where needed for anyone requiring this patch.
You are right.

I thought it is possible to use debug_lines without any information from the debug_info section but it is more complicated then that. In this case it would be almost as complicated to skip the problematic entries as to teach LLDB how to handle them.


https://reviews.llvm.org/D35734