[Lldb-commits] [PATCH] D35734: Don't allow LLDB to try and parse .debug_types

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer added a comment.

This section have been already removed from Dwarf5 so I agree that we shouldn't spend too much time adding support for it. Do you know anybody hitting this issue? Do you know why they decided to use this flag?



================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:500-513
+    // On non Apple platforms we might have .debug_types debug info that
+    // is created by using "-fdebug-types". LLDB currently will try to
+    // load this debug info, but it causes crashes during debugging when
+    // types are missing since it doesn't know how to parse the info in
+    // the .debug_types type units. This causes all complex debug info
+    // types to be unresolved. Because this causes LLDB to crash and since
+    // it really doesn't provide a solid debuggiung experience, we should
----------------
Can we make this disabling logic a bit more fine grained? What I am thinking about is to disable parsing .debug_info and .debug_types but still parse the line table as that shouldn't cause any issue.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:501
+    // On non Apple platforms we might have .debug_types debug info that
+    // is created by using "-fdebug-types". LLDB currently will try to
+    // load this debug info, but it causes crashes during debugging when
----------------
I think the name of the flag is "-fdebug-types-section" but it might be platform dependent.


https://reviews.llvm.org/D35734